Exclude old incompatible jc-kzg-4844 artefact #8704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Since upgrading to the new version of
jc-kzg-4844which uses a differentgroupId, there is a clash with Besu dependencies which are still on the old version under a differentgroupId. This causes our final build under/libto include both jars which causes issues for Windows users. Ubuntu does not seem affected. Issue was captured in ethStaker discord: https://discord.com/channels/694822223575384095/782670046736285697/1293796201610870846Also replicated locally on a Windows machine with the latest release
A manual workaround was needed (delete
jc-kzg-4844-1.0.0.jarfrom/lib) in order for Teku to start.Fixed Issue(s)
N/A
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog